Skip to content

binder: rework server SecurityPolicy future handling - #12954

Open
jdcormie wants to merge 4 commits into
grpc:masterfrom
jdcormie:jdcormie-binder-dedup-cancellation
Open

binder: rework server SecurityPolicy future handling#12954
jdcormie wants to merge 4 commits into
grpc:masterfrom
jdcormie:jdcormie-binder-dedup-cancellation

Conversation

@jdcormie

@jdcormie jdcormie commented Jul 29, 2026

Copy link
Copy Markdown
Member

Will not squash. Please consider each commit on its own.

@jdcormie
jdcormie force-pushed the jdcormie-binder-dedup-cancellation branch 2 times, most recently from c80e3d9 to b2fbe47 Compare July 30, 2026 00:21
@jdcormie jdcormie changed the title binder: fix SecurityPolicy handling on the server binder: rework server SecurityPolicy future handling Jul 30, 2026
@jdcormie
jdcormie force-pushed the jdcormie-binder-dedup-cancellation branch 3 times, most recently from 07e3a18 to 23be448 Compare July 30, 2026 08:29
@mateusazis
mateusazis self-requested a review July 30, 2026 16:31
@jdcormie
jdcormie force-pushed the jdcormie-binder-dedup-cancellation branch from 23be448 to 21328cf Compare August 4, 2026 01:14
Comment thread binder/src/test/java/io/grpc/binder/RobolectricBinderSecurityTest.java Outdated
Comment thread binder/src/test/java/io/grpc/binder/RobolectricBinderSecurityTest.java Outdated
Comment thread binder/src/test/java/io/grpc/binder/internal/TransportAuthorizationStateTest.java Outdated
Comment thread binder/src/test/java/io/grpc/binder/internal/TransportAuthorizationStateTest.java Outdated
Comment thread binder/src/test/java/io/grpc/binder/RobolectricBinderSecurityTest.java Outdated
Comment thread binder/src/test/java/io/grpc/binder/RobolectricBinderSecurityTest.java Outdated
Comment thread binder/src/test/java/io/grpc/binder/RobolectricBinderSecurityTest.java Outdated
RobolectricBinderSecurityTest has some tests already but some corners of
this class are hard to reach without flakiness at the Channel/Server
layer.
Include uncached methods in the deduping logic too.
@jdcormie
jdcormie force-pushed the jdcormie-binder-dedup-cancellation branch from 21328cf to 7646850 Compare August 5, 2026 00:36
@jdcormie
jdcormie requested a review from kannanjgithub August 5, 2026 00:42
@jdcormie

jdcormie commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

@kannanjgithub would you please consider this for approval?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

binder: Server fails to cancel SecurityPolicy.checkAuthorization() futures before termination

2 participants